record memory and op supplement info #43550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… record_memory_and_op_supplement_info_for_profiler
liutiexing
requested changes
Jun 16, 2022
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <map> | |||
| #include <stack> | |||
liutiexing
previously approved these changes
Jun 16, 2022
From00
reviewed
Jun 21, 2022
| @@ -26,6 +27,9 @@ void CPUPinnedAllocator::FreeImpl(phi::Allocation *allocation) { | |||
| PADDLE_ENFORCE_GPU_SUCCESS(cudaFreeHost(allocation->ptr())); | |||
| #endif | |||
| HOST_MEMORY_STAT_UPDATE(Reserved, 0, -allocation->size()); | |||
| platform::RecordMemEvent(allocation->ptr(), allocation->place(), | |||
There was a problem hiding this comment.
Should pass CPUPlace here? Better to handle GPUPinnedPlace in the implement of RecordMemEvent.
| @@ -54,6 +57,9 @@ class StatAllocator : public Allocator { | |||
| DEVICE_MEMORY_STAT_UPDATE(Allocated, place.GetDeviceId(), | |||
| allocation->size()); | |||
| } | |||
| platform::RecordMemEvent(allocation->ptr(), allocation->place(), | |||
There was a problem hiding this comment.
The same problem as above to handle GPUPinnedPlace
|
|
||
| RecordMemEvent::RecordMemEvent(const void *ptr, const phi::Place &place, | ||
| size_t size, const TracerMemEventType type) { | ||
| if (g_state == ProfilerState::kDisabled && |
There was a problem hiding this comment.
Better to keep consistent of the curly braces requirement in if statement. Since elsewhere you add a curly brace for if even though the statement is brief, better to add here.
This reverts commit c1d4df5.
… record_memory_and_op_supplement_info_for_profiler
… record_memory_and_op_supplement_info_for_profiler
lanxianghit
approved these changes
Jun 23, 2022
sneaxiy
pushed a commit
to sneaxiy/Paddle
that referenced
this pull request
Jun 27, 2022
* record memory and op supplement info * update * update * fix a bug * fix memory recording * fix a bug * update * update * fix a bug * update * fix a bug * fix a bug * fix a bug * Revert "fix a bug" This reverts commit c1d4df5. * fix a bug * fix format * fix
rainyfly
added a commit
to rainyfly/Paddle
that referenced
this pull request
Jul 15, 2022
* record memory and op supplement info * update * update * fix a bug * fix memory recording * fix a bug * update * update * fix a bug * update * fix a bug * fix a bug * fix a bug * Revert "fix a bug" This reverts commit c1d4df5. * fix a bug * fix format * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe